1724 tab navigation for ModalProposals #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1738 +/- ##
========================================
Coverage 97.74% 97.74%
========================================
Files 102 102
Lines 2086 2086
Branches 93 93
========================================
Hits 2039 2039
Misses 38 38
Partials 9 9
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## develop #1738 +/- ##
========================================
Coverage 97.74% 97.74%
========================================
Files 102 102
Lines 2086 2086
Branches 93 93
========================================
Hits 2039 2039
Misses 38 38
Partials 9 9
|
Codecov Report
@@ Coverage Diff @@
## develop #1738 +/- ##
========================================
Coverage 97.74% 97.74%
========================================
Files 102 102
Lines 2086 2086
Branches 93 93
========================================
Hits 2039 2039
Misses 38 38
Partials 9 9
|
|
Thank you very much for your contribution. :) |
faboweb
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1724
Tab navigation now skips readonly denom in ModalProposals. This seems to be the only readonly element that was causing "improper" tab navigation.